Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate build rules for specific language files from action/build #563

Merged
merged 29 commits into from
Sep 4, 2019

Conversation

waruqi
Copy link
Member

@waruqi waruqi commented Aug 31, 2019

Make action/build more lightweight, just include the processing logic for the rules. Extract c++ related build action into the c++ rules.

This way we can more easily extend and customize the language-specific build process and prepare for implementing C++ modules #386.

Roadmap

  • Rules
    • c++
    • win.sdk.resource
    • objc++
      • objc.build
      • objc++.build
    • swift
      • swift.build
    • rust
      • rust.build
    • go
      • go.build
    • dlang
      • dlang.build
    • cuda
      • cuda.build
        • cuda.build.devlink
      • cuda.gencodes
    • utils
      • utils.merge.object, add_files("*.o", "*.obj")
      • utils.merge.archive, add_files("*.a", "*.lib")
  • Modules
    • private.tools.ccache
    • private.action.build.object
    • private.action.build.pcheader

@waruqi waruqi added this to the v2.2.9 milestone Aug 31, 2019
@waruqi waruqi changed the title Separate build rules for specific language files from action/build [WIP]: Separate build rules for specific language files from action/build Aug 31, 2019
@waruqi waruqi changed the title [WIP]: Separate build rules for specific language files from action/build Separate build rules for specific language files from action/build Sep 3, 2019
@waruqi waruqi marked this pull request as ready for review September 3, 2019 04:16
@waruqi
Copy link
Member Author

waruqi commented Sep 3, 2019

@OpportunityLiu 我这边重构了下build action,打薄后,逐步吧build实现分离到特定的rules中,改动比较大,你这边试试是否运行正常,比如cuda/vsxmake深得,如果没啥问题,我就先merge进去了

我这边初步测试各个模块,没测出啥问题。

@waruqi waruqi added done and removed in progress labels Sep 4, 2019
@waruqi waruqi merged commit 1a1eac4 into dev Sep 4, 2019
@waruqi waruqi deleted the buildrules branch September 4, 2019 02:09
@OpportunityLiu
Copy link
Member

图片

@waruqi
Copy link
Member Author

waruqi commented Sep 5, 2019

我修复了

@waruqi
Copy link
Member Author

waruqi commented Sep 6, 2019

c++.build.modules @see #569

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants