New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reloading the app when offline and in memory mode should show an error #169

Closed

xMartin opened this issue Dec 25, 2019 · 0 comments

Labels

bug ready to implement

Owner

xMartin commented Dec 25, 2019

Steps to reproduce:

Open tab in Firefox private window
Switch to offline mode
Refresh page

Expected result:

Show import error as tab data cannot be loaded either locally or remotely

Actual result:

Showing empty tab state with no name

This edge case appears because we have the tab ID already in local storage but the data is gone as it was only in memory.

xMartin added bug ready to implement labels

xMartin added a commit that referenced this issue


          Display error if tab info is missing (#169)

7b31df8

xMartin closed this as completed in

d58f982

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment