Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multivalued section row deletion does not work in succession #1674

Closed
AndrewBennet opened this issue Oct 2, 2018 · 6 comments
Closed

Multivalued section row deletion does not work in succession #1674

AndrewBennet opened this issue Oct 2, 2018 · 6 comments
Labels
section: MultivaluedSection type: issue

Comments

@AndrewBennet
Copy link
Contributor

When using a multivalued section which allows row deletion, if two rows are deleted, and the second is deleted while the animation for the first deletion is still running, the second deletion does not occur and the section becomes frozen.

This is demonstrable in the example Eureka app by just deleting the top two rows of the multivalued section in quick succession. (This is hard to do on a simulator though).

image

Eureka version: 4.3.0
Xcode version: 10.0
iOS: 12.0
@AndrewBennet
Copy link
Contributor Author

Do you know if there is any workaround for this issue?

@mats-claassen
Copy link
Member

Not to my knowledge but it might be related to #1575. I don't think it's the same issue though

@serbuk
Copy link

serbuk commented Oct 13, 2018

I faced exactly the same issue. The whole form (all the available sections) becomes frozen.

@ykorshev
Copy link

Any updates?

mats-claassen added a commit that referenced this issue Nov 1, 2018
@mats-claassen
Fix #1674 by removing double isEditing switch
db1742e
@mats-claassen mats-claassen mentioned this issue Nov 1, 2018
Merged
mtnbarreto added a commit that referenced this issue Dec 5, 2018
@mtnbarreto
Merge pull request #1709 from xmartlabs/multivalued_delete
9678a49 
Fix #1674 by removing double `isEditing` switch
chefren pushed a commit to chefren/Eureka that referenced this issue Dec 17, 2018
@tCInUBkXfaMY
Merge branch 'master' into docs-corrections
8a0e911 
* master: (130 commits)
  add default arg value to makeRowVisible method
  titlePercentage added for textAreaRow (xmartlabs#1707)
  feat: adjusts property name and didSet. Adjust the tests accordingly
  feat: allow the row to reset its value to the default
  fix: Cell disappears because of keyboard scrolling xmartlabs#1597 (xmartlabs#1723)
  add UIKit imports to get buck to build (xmartlabs#1717)
  Fix xmartlabs#1674 by removing double `isEditing` switch
  Add `allRows` variable to Section
  Introduce NavigationAccessory in order to provide totally custom AccessoryView (xmartlabs#1397)
  Avoid segmented row title label pushing value out of bounds
  Fix StepperRow title label overlapping stepper
  Set textContentType for relevant cells (xmartlabs#1698)
  Adding `includeDisabled` to validate method
  Convert tests to Swift 4.2 syntax
  Fix Slider constraints
  Some version changes in project. And fixed SliderRow example
  Declare swift language version required in podspec (xmartlabs#1665)
  Release 4.3.0
  Fix multivalued delete button was not appearing (xmartlabs#1664)
  fix comments
  ...

# Conflicts:
#	Source/Core/Form.swift
@hungeric
Copy link

Hello @mats-claassen did your #1709 fix the frozen thing @serbuk mentioned in the comment above?
also is the fix released?

@mats-claassen
Copy link
Member

It should be fixed in version 4.3.1 released yesterday

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
section: MultivaluedSection type: issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@AndrewBennet @hungeric @mats-claassen @serbuk @ykorshev