Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SplitRow #1338

Closed
wants to merge 2 commits into from
Closed

SplitRow #1338

wants to merge 2 commits into from

Conversation

marbetschar
Copy link
Contributor

I'll created a new custom row called SplitRow which enables users to display two Eureka rows on the same line using the following signature:

form +++ Section()
	<<< SplitRow<PushRow<String>,TextRow>(){
		$0.rowLeft = PushRow<String>(){
			$0.selectorTitle = "E-Mail"
			$0.options = ["Private","Work","Others"]
		}
					
		$0.rowRight = TextRow(){
			$0.placeholder = "E-Mail"
		}
				
	}.onChange{
		print("SplitRow.onChange:","left:",$0.value?.left,"right:",$0.value?.right)
	}

Here's how it looks like:

splitrow

I'll happily submit the SplitRow to the Eureka Community but it needs this pull request to be merged into Eureka first to work properly.

Marco Betschart added 2 commits December 2, 2017 15:45
In order to allow it to be overwritten by a row which subclasses it. This is needed for the new custom row `SplitRow`. `SplitRow` enables to put two Eureka rows side by side into one UITableViewCell.
@marbetschar
Copy link
Contributor Author

As promised, SplitRow is now part of the Eureka Community project:

https://github.com/EurekaCommunity/SplitRow

marbetschar pushed a commit to Mandelkind/SuggestionRow that referenced this pull request Dec 6, 2017
Added support for the Eureka build which is Swipe and SplitRow aware. This is a temporary branch till these pull requests are merged:

- xmartlabs/Eureka#1338
- xmartlabs/Eureka#1249
@marbetschar
Copy link
Contributor Author

marbetschar commented Dec 11, 2017

I'd also love to add a Pull Request for the PostalAddressRow, which newly supports the country selection: https://github.com/Mandelkind/PostalAddressRow/tree/pushrow-country-selector

But we have to get this one merged first in order to get the updated PostalAddressRow working properly.

EurekaCommunity/PostalAddressRow#3

@mtnbarreto
Copy link
Member

Hi @marbetschar. The row looks great!
I will close this pr since you already added the row to eureka community which is the proper place to provide these kind of features.

@mtnbarreto mtnbarreto closed this Dec 11, 2017
@marbetschar
Copy link
Contributor Author

Missunderstanding here. SplitRow needs this change in Eureka in order to work properly:

be4c01d

@marbetschar
Copy link
Contributor Author

@mtnbarreto will this be merged too?

@liorp
Copy link

liorp commented Dec 17, 2017

Is there any progress on commit be4c01d?

@marbetschar
Copy link
Contributor Author

@mtnbarreto will thevar section be open in a future Eureka release?

@marbetschar marbetschar deleted the SplitRow branch January 5, 2018 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants