Better row deselection behavior during interactive transitions #406
Conversation
| tableView?.selectRowAtIndexPath($0, animated: false, scrollPosition: .None) | ||
| } | ||
|
|
||
| let deselectionAnimation = { (context: UIViewControllerTransitionCoordinatorContext) in |
There was a problem hiding this comment.
@ZevEisenberg [weak self] should be added in the closure, right? same applies to reselection closure. I can make these changes if you agree on them.
There was a problem hiding this comment.
@mtnbarreto no need to [weak self], since you're in an animation block that self is not retaining. Only need [weak self] when the thing that the block is capturing (and therefore retaining) is also retaining the block. Here, the animation system is holding the block, and will eventually release it, which will then release the captured self.
There was a problem hiding this comment.
Got it. I'm not completely sure how swift manage these references and which one is released first. I've already added the [weak self], the result should be the same. Note that i didn't add it to foreach since it explicitly declare @noescape.
There was a problem hiding this comment.
Fair enough. A good rule of thumb is that if it's an animation block, and it's going to run once, then it's fine to not use [weak self]. If it's a repeating animation, more care must be taken, because the animation system will retain the block indefinitely, so you can't rely on canceling the animation in deinit (for example).
Closes #405