Fix crash when .Nib is inside a framework bundle. #1050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mats-claassen
requested changes
May 14, 2019
| @@ -155,7 +156,9 @@ -(XLFormBaseCell *)cellForFormController:(XLFormViewController * __unused)formCo | |||
|
|
|||
| if ([bundle pathForResource:cellResource ofType:@"nib"]) { | |||
| _cell = [[bundle loadNibNamed:cellResource owner:nil options:nil] firstObject]; | |||
| } else { | |||
| }else if([bundleForCaller pathForResource:cellResource ofType:@"nib"]){ | |||
There was a problem hiding this comment.
Please respect the style guide: Add a space after } and before { and (.
Same thing below in else
mrcararia
commented
May 14, 2019
mats-claassen
approved these changes
May 14, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to wrap XLForm inside a private framework and implement custom cells.
In this scenario a crash is obtained because the .nib file is not found inside the main bundle.
It is necessary to look for it within the private framework bundle.
This fix the issue.