Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for distribution via Swift Package Manager (SwiftPM) #1073

Merged
merged 8 commits into from
Sep 23, 2020

Conversation

eneko
Copy link
Contributor

@eneko eneko commented Sep 17, 2020

This PR adds support for distributing XLForm via Swift Package Manager. This would allow users of Xcode 11 and above to add XLForm as a dependency using Xcode's integrated UI.

Screen Shot 2020-09-17 at 10 58 07 AM

Summary of Changes

  • Add Package.swift
  • Flatten file structure to ensure consuming applications can find all public header files, without having to manually specify header search paths. Project structure in XLForm.xcodeproj has been unaltered.

Testing

To manually test distribution via XLForm:

  1. On a new or existing project in Xcode
  2. Go toFile -> Swift Packages -> Add Package Dependency...
  3. Enter url https://github.com/eneko/XLFom
  4. Choose branch master
  5. Use XLForm in your app 🎉

@eneko
Copy link
Contributor Author

eneko commented Sep 17, 2020

@mats-claassen could you please re-run the CI build on Travis? CocoaPods was timing out this morning, but it's working again. Build is passing on my end: https://travis-ci.com/github/eneko/XLForm/builds/185000478

@mats-claassen
Copy link
Member

Hi @eneko do you mind also adding a note to the Readme on how to install using SPM?

@eneko
Copy link
Contributor Author

eneko commented Sep 21, 2020

Hi @mats-claassen, sounds good. PR updated.

README.md Outdated Show resolved Hide resolved
Co-authored-by: Mathias Claassen <mathiasclaassen7@gmail.com>
@mats-claassen mats-claassen merged commit 0e5da84 into xmartlabs:master Sep 23, 2020
@eneko
Copy link
Contributor Author

eneko commented Sep 23, 2020

Thank you, @mats-claassen 🎉

When you have a chance, could you tag a new release? Both 4.1.1 or 4.2.0 would work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants