Fixed #357 by adding XL_APP_EXTENSIONS macro so that XLForm can be used in App Extensions #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…can be used in App Extensions
|
+1 to making XLForm work with app extensions, even if it is necessary to sacrify the alert views... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similarly solved as in SVProgressHUD, discussion here: https://github.com/TransitApp/SVProgressHUD/issues/432
There is no other way for app extensions to work than using a user-defined preprocessor macro, because you would otherwise end up with compile-time errors.
Would be great if XLForm would support App Extensions! The
XL_APP_EXTENSIONSmacro wouldn't do any harm on current projects, because the macro isn't defined in normal cases. It has to be explicitly defined for app extension targets.