updated to Swift 4.2 and added swift version to podspec #617
Conversation
|
Hello @mtnbarreto ! Could you check this pull request? |
|
I would also like to see this merge come through. |
|
I decided to temporarily use Alexander repo directly, you can do it like this if you want : pod 'XLPagerTabStrip', git: 'https://github.com/alexanderkhitev/XLPagerTabStrip', branch: 'master' |
Sources/ButtonBarViewCell.swift
Outdated
| @@ -33,8 +33,7 @@ open class ButtonBarViewCell: UICollectionViewCell { | |||
| super.init(coder: aDecoder) | |||
|
|
|||
| isAccessibilityElement = true | |||
| accessibilityTraits |= UIAccessibilityTraitButton | |||
| accessibilityTraits |= UIAccessibilityTraitHeader | |||
| accessibilityTraits = [.button, .header] | |||
There was a problem hiding this comment.
I think you should use the insert or formUnion function here. The previous logic was adding the two traits to whatever was already in accessibilityTraits.
Sources/ButtonBarViewCell.swift
Outdated
| @@ -44,9 +43,9 @@ open class ButtonBarViewCell: UICollectionViewCell { | |||
| set { | |||
| super.isSelected = newValue | |||
| if (newValue) { | |||
| accessibilityTraits |= UIAccessibilityTraitSelected | |||
| accessibilityTraits = [.selected] | |||
There was a problem hiding this comment.
Again. use accessibilityTraits.insert(.selected)
Sources/ButtonBarViewCell.swift
Outdated
| } else { | ||
| accessibilityTraits &= ~UIAccessibilityTraitSelected | ||
| accessibilityTraits.formUnion(.selected) |
There was a problem hiding this comment.
And here you should remove selected and not add it: accessibilityTraits.remove(.selected)
| @@ -349,8 +349,7 @@ open class ButtonBarPagerTabStripViewController: PagerTabStripViewController, Pa | |||
| } | |||
| cell.isAccessibilityElement = true | |||
| cell.accessibilityLabel = cell.label.text | |||
| cell.accessibilityTraits |= UIAccessibilityTraitButton | |||
| cell.accessibilityTraits |= UIAccessibilityTraitHeader | |||
| cell.accessibilityTraits = [.button, .header] | |||
There was a problem hiding this comment.
@mats-claassen thanks, it done
No description provided.