Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unixtime to weekly time needs to be written. #26

Closed
schmidtw opened this issue Oct 24, 2017 · 3 comments
Closed

Unixtime to weekly time needs to be written. #26

schmidtw opened this issue Oct 24, 2017 · 3 comments

Comments

@schmidtw
Copy link
Member

Right now the actual converter does nothing, but the unixtime to weekly time needs to be finished. Of note - we need to ensure that the time changes are accounted for correctly.

Correct behavior for the time change:

  • Only the most recent event in the window of time that is truncated is applied
  • During the repeated windows of time, the schedule is also repeated as thou that there was not an immediate repeat.
  • Ensure that the correct next event window is calculated so Aker doesn't sleep for too long.
@schmidtw
Copy link
Member Author

schmidtw commented Oct 24, 2017

Add some unit tests showing:

  • during known DST windows we get the expected results (one springing forward & one falling back)
  • during non DST shifts show that a couple values are right

Then this is done :)

@manderiasian
Copy link
Contributor

I am confused Unix time to weekly time gets a time_t, does that already have any DST applied to it?
Also, localtime() returns a value for "in DST", but the values are correct, how would we use the "in DST" to do any testing? And if the schedule transmitted was based on pre-dst change, ...too many questions.

@schmidtw
Copy link
Member Author

schmidtw commented Jan 2, 2018

This can be marked done because the tests in https://github.com/Comcast/aker/blob/master/tests/test_time_changes.c

@schmidtw schmidtw closed this as completed Jan 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants