Abstract Dynamodb dependendy #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joe94
force-pushed
the
feature/dynamoRefactor
branch
from
f0c6f4f
to
f242419
Compare
Codecov Report
@@ Coverage Diff @@
## main #35 +/- ##
=========================================
- Coverage 11.61% 7.96% -3.65%
=========================================
Files 13 12 -1
Lines 818 753 -65
=========================================
- Hits 95 60 -35
+ Misses 703 679 -24
+ Partials 20 14 -6
Continue to review full report at Codecov.
|
joe94
added
the
enhancement
|
SonarCloud Quality Gate failed.
|
johnabass
approved these changes
Sep 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main change introduced in this PR is creating an interface that defines the interactions we expect the dynamodb api to provide.
This makes our code a lot easier to unit test through mocks.