Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Tracing Options More Configurable #102

Closed
renaz6 opened this issue Feb 21, 2023 · 0 comments · Fixed by #104
Closed

Make Tracing Options More Configurable #102

renaz6 opened this issue Feb 21, 2023 · 0 comments · Fixed by #104
Assignees

Comments

@renaz6
Copy link
Member

renaz6 commented Feb 21, 2023

Based on a comment from Wes on #100

if we split apart the choices a bit more we can let the user decide what they want without us needing to do much & we can expand/grow later.

Replace sampleLocalTraces with:

sampling-strategy:
   parent-initiated: ignore # [ignore (default), honor]
   no-parent: never         # [never (default), always, traceidratio, ...]
   traceidratio:            # For each sampler that needs inputs they get enumerated separately.
       percentage: 15.5

Choosing the quietest mode (completely off) as defaults.

Until we need to add traceidratio we can just know it goes here. I think @Sachin4403 may want:

  sampling-strategy:
    parent-initiated: honor
    no-parent: always

We'll probably want to use:

  sampling-strategy:
    parent-initiated: honor
    no-parent: never

We can add the traceidratio later if someone wants/needs it.

@renaz6 renaz6 self-assigned this Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant