Improve Tracing Configurations #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
renaz6
commented
Feb 22, 2023
•
renaz6
commented
- Closes Make Tracing Options More Configurable #102
- Splitting up the tracing configuration changes so the user can decide exactly what gets traced and when
Codecov Report
@@ Coverage Diff @@
## main #104 +/- ##
==========================================
+ Coverage 73.46% 77.20% +3.73%
==========================================
Files 4 4
Lines 196 215 +19
==========================================
+ Hits 144 166 +22
+ Misses 46 44 -2
+ Partials 6 5 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This was referenced Feb 23, 2023
johnabass
approved these changes
Feb 27, 2023
schmidtw
reviewed
Mar 1, 2023
config.go
Outdated
|
|
||
| // NoParent decides if a root span should be initiated in the case where there is no existing parent | ||
| // This value is ignored if ParentBased = "ignore" | ||
| // "never" is the default value |
There was a problem hiding this comment.
Is there a value of always also available?
There was a problem hiding this comment.
Yes, there is. I'll add it to the comment as well.
|
Kudos, SonarCloud Quality Gate passed! |
schmidtw
approved these changes
Mar 1, 2023
Merged
This was referenced Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.