Skip to content

Commit

Permalink
more test coverage
Browse files Browse the repository at this point in the history
  • Loading branch information
Marcia Piccione authored and Marcia Piccione committed Feb 21, 2023
1 parent b287856 commit 6cd21e8
Showing 1 changed file with 9 additions and 9 deletions.
18 changes: 9 additions & 9 deletions kratos_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ var (
fmt.Println("hi")
return nil
},
ClientLogger: sallust.Default(),
ClientLogger: nil,
PingConfig: PingConfig{},
}

Expand Down Expand Up @@ -220,15 +220,15 @@ func TestNew_NoPingMissHandler(t *testing.T) {
assert.Equal(err, errNilHandlePingMiss)
}

// func TestNew_ClientLoggerNotNil(t *testing.T) {
// logger := sallust.Default()
// clientConfigHasLogger := clientConfig
// clientConfigHasLogger.ClientLogger = logger
// assert := assert.New(t)
// _, err := NewClient(clientConfigHasLogger)
func TestNew_ClientLoggerNotNil(t *testing.T) {
logger := sallust.Default()
clientConfigHasLogger := clientConfig
clientConfigHasLogger.ClientLogger = logger
assert := assert.New(t)
_, err := NewClient(clientConfigHasLogger)

// assert.Nil(err)
// }
assert.Nil(err)
}

func Error(s string) {
panic("unimplemented")
Expand Down

0 comments on commit 6cd21e8

Please sign in to comment.