New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opentelemetry changes for Petasos #67
Conversation
Codecov Report
@@ Coverage Diff @@
## main #67 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 1 1
Lines 77 100 +23
=====================================
- Misses 77 100 +23
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Passing this on to some other team members who also have good knowledge of this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In case you haven't, please run go mod tidy
.
Otherwise, it looks good! 🎉
Hi Joe. I ran go mod tidy again. Kindly review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good. I left some questions for @johnabass
No description provided.