Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opentelemetry changes for Petasos #67

Merged
merged 6 commits into from May 1, 2021
Merged

Conversation

utsavbatra5
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Mar 24, 2021

Codecov Report

Merging #67 (567ebb1) into main (bf33c14) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main     #67   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          1       1           
  Lines         77     100   +23     
=====================================
- Misses        77     100   +23     
Impacted Files Coverage Δ
main.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf33c14...567ebb1. Read the comment docs.

@schmidtw schmidtw requested a review from johnabass March 30, 2021 05:58
Copy link
Contributor

@johnabass johnabass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Passing this on to some other team members who also have good knowledge of this.

@johnabass johnabass requested review from kristakhare, joe94, kcajmagic and kristinapathak and removed request for kristakhare April 1, 2021 05:02
Copy link
Member

@joe94 joe94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case you haven't, please run go mod tidy.
Otherwise, it looks good! 🎉

@utsavbatra5
Copy link
Contributor Author

Hi Joe. I ran go mod tidy again. Kindly review.

Copy link
Member

@kcajmagic kcajmagic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good. I left some questions for @johnabass

deploy/packaging/petasos_spruce.yaml Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
@joe94 joe94 linked an issue Apr 28, 2021 that may be closed by this pull request
deploy/packaging/petasos_spruce.yaml Outdated Show resolved Hide resolved
petasos.yaml Outdated Show resolved Hide resolved
petasos.yaml Outdated Show resolved Hide resolved
@joe94 joe94 merged commit ffc5507 into xmidt-org:main May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add optional OpenTelemetry tracing
5 participants