pruned deprecated code and code that shouldn't be maintained any longer #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## main #43 +/- ##
==========================================
+ Coverage 98.93% 99.35% +0.42%
==========================================
Files 17 12 -5
Lines 657 467 -190
==========================================
- Hits 650 464 -186
+ Misses 6 2 -4
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
denopink
reviewed
Nov 30, 2022
Comment on lines
-69
to
-78
|
|
||
| // GetDefaultLogger returns the default logger, which doesn't do anything. | ||
| func GetDefaultLogger(_ context.Context) *zap.Logger { | ||
| return Default() | ||
| } | ||
|
|
||
| // GetNilLogger returns nil. | ||
| func GetNilLogger(_ context.Context) *zap.Logger { | ||
| return nil | ||
| } |
There was a problem hiding this comment.
cool, I just removed these references from other servers
denopink
reviewed
Nov 30, 2022
Comment on lines
-13
to
-16
| // GetLoggerFunc is the function used to get a request-specific logger from | ||
| // its context. | ||
| type GetLoggerFunc func(context.Context) *zap.Logger | ||
|
|
There was a problem hiding this comment.
cool, I just removed this type from servers that were using it
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prunes out code we don't want any longer and code that duplicates existing functionality.