Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add response check when getting SAT #59

Closed
kristinapathak opened this issue Apr 16, 2019 · 0 comments · Fixed by #60
Closed

Add response check when getting SAT #59

kristinapathak opened this issue Apr 16, 2019 · 0 comments · Fixed by #60
Assignees
Labels
bug Something isn't working

Comments

@kristinapathak
Copy link
Contributor

https://github.com/Comcast/codex-svalinn/blob/3852ee1459bd639f8f595bc33804ecd41e1ae24d/webhook/sat.go#L51

Around here, we need to add a check to see if we got a 200 response or not, and error out if we do. Otherwise, we just get an empty token

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant