Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Application Versioning #111

Merged
merged 1 commit into from
Oct 8, 2019

Conversation

kcajmagic
Copy link
Member

This will allow for better bug reports and information the binary running.
For example if you build a docker image with make local-docker you can get the version with the command docker run --rm xmidt/svalinn:local -v.

svalinn:
  version:      0.12.0+local
  go version:   go1.12.1
  built time:   2019-10-08 22:24:14
  git commit:   2b26b52
  os/arch:      linux/amd64

@kcajmagic kcajmagic added the hacktoberfest https://comcast.github.io/hacktoberfest label Oct 8, 2019
@kcajmagic kcajmagic added this to In progress in Codex via automation Oct 8, 2019
@codecov-io
Copy link

Codecov Report

Merging #111 into master will decrease coverage by 0.88%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #111      +/-   ##
=========================================
- Coverage   47.98%   47.1%   -0.89%     
=========================================
  Files           6       6              
  Lines         373     380       +7     
=========================================
  Hits          179     179              
- Misses        189     196       +7     
  Partials        5       5
Impacted Files Coverage Δ
main.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c846ee...2b26b52. Read the comment docs.

Codex automation moved this from In progress to Reviewer approved Oct 8, 2019
Copy link
Contributor

@kristinapathak kristinapathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest https://comcast.github.io/hacktoberfest
Projects
Codex
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants