Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Event related metrics fail to update #361

Closed
denopink opened this issue Jan 13, 2023 · 0 comments · Fixed by #367
Closed

Bug: Event related metrics fail to update #361

denopink opened this issue Jan 13, 2023 · 0 comments · Fixed by #367
Assignees
Labels
bug webpa-common archival/deprecation work related to the archival & deprecation of webpa-common

Comments

@denopink
Copy link
Contributor

denopink commented Jan 13, 2023

Currently, the watchers are stopped before the server even starts:

tr1d1um/primaryHandler.go

Lines 163 to 169 in 09f928c

stopWatches, err := svc.StartListener(listenerMeasures, sallust.With)
if err != nil {
return out, fmt.Errorf("webhook service start listener error: %s", err)
}
in.Logger.Info("Webhook service enabled")
defer stopWatches()

@denopink denopink added bug webpa-common archival/deprecation work related to the archival & deprecation of webpa-common labels Jan 13, 2023
@denopink denopink self-assigned this Jan 13, 2023
denopink added a commit that referenced this issue Jan 19, 2023
@denopink denopink changed the title Ancla listeners should stop during shutdown Bug: Add ancla watcher to fx lifecycle Jan 19, 2023
@denopink denopink changed the title Bug: Add ancla watcher to fx lifecycle Bug: Event related metrics fail to update Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug webpa-common archival/deprecation work related to the archival & deprecation of webpa-common
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant