Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add strategy to disable verbose transation logs #145

Merged
merged 2 commits into from
Feb 18, 2020

Conversation

joe94
Copy link
Member

@joe94 joe94 commented Feb 18, 2020

No description provided.

@codecov-io
Copy link

codecov-io commented Feb 18, 2020

Codecov Report

Merging #145 into master will decrease coverage by 1.43%.
The diff coverage is 20.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #145      +/-   ##
==========================================
- Coverage   79.45%   78.01%   -1.44%     
==========================================
  Files          11       11              
  Lines         404      414      +10     
==========================================
+ Hits          321      323       +2     
- Misses         82       90       +8     
  Partials        1        1
Impacted Files Coverage Δ
translation/transport.go 87.94% <0%> (ø) ⬆️
stat/transport.go 68.29% <0%> (ø) ⬆️
common/utils.go 60.56% <21.87%> (-6.65%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d77bc09...e0b6799. Read the comment docs.

Copy link
Contributor

@kristinapathak kristinapathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@joe94 joe94 merged commit 7ed4dd0 into master Feb 18, 2020
@joe94 joe94 deleted the feature/configurableTransactionLogger branch February 18, 2020 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants