added endpoint regex for capabilityCheck metric #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joe94
reviewed
Feb 21, 2020
main.go
Outdated
| for _, e := range capabilityCheck.EndpointBuckets { | ||
| r, err := regexp.Compile(e) | ||
| if err != nil { | ||
| logging.Warn(logger).Log(logging.MessageKey(), "failed to compile regular expression", "regex", e, logging.ErrorKey(), err.Error()) |
There was a problem hiding this comment.
do we want to continue starting tr1d1um even when some endpoints were not loaded?
There was a problem hiding this comment.
I think so - a metric not configured quite correctly won't stop tr1d1um from doing its main job. What do you think? I'm open to erroring out; I can also change the log to error, to make sure it gets picked up.
kcajmagic
approved these changes
Feb 21, 2020
Codecov Report
@@ Coverage Diff @@
## master #147 +/- ##
==========================================
+ Coverage 78.01% 78.33% +0.31%
==========================================
Files 11 11
Lines 414 420 +6
==========================================
+ Hits 323 329 +6
+ Misses 90 89 -1
- Partials 1 2 +1
Continue to review full report at Codecov.
|
joe94
approved these changes
Feb 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
builds off of xmidt-org/webpa-common#459