Auth token creation option #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #140 |
joe94
requested review from
kristinapathak,
gargidb,
johnabass and
kcajmagic
Codecov Report
@@ Coverage Diff @@
## master #148 +/- ##
==========================================
- Coverage 78.33% 77.54% -0.79%
==========================================
Files 11 11
Lines 420 432 +12
==========================================
+ Hits 329 335 +6
- Misses 89 92 +3
- Partials 2 5 +3
Continue to review full report at Codecov.
|
kristinapathak
suggested changes
Feb 25, 2020
stat/service.go
Outdated
| @@ -35,17 +39,26 @@ type service struct { | |||
| //request to the XMiDT API and return only data we care about | |||
| common.Tr1d1umTransactor | |||
|
|
|||
| acquire.Acquirer | |||
|
|
|||
| XmidtStatURL string | |||
There was a problem hiding this comment.
I know this isn't a part of your pr, but why is this public?
translation/service.go
Outdated
Comment on lines
51
to
53
| XmidtWrpURL string | ||
|
|
||
| WRPSource string |
There was a problem hiding this comment.
Similar to my previous comment, I'm not sure why these are public?
Co-Authored-By: kristinaspring <kmspring57@gmail.com>
kcajmagic
approved these changes
Feb 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.