Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switched SNS to argus #168

Merged
merged 6 commits into from
Jul 7, 2020
Merged

switched SNS to argus #168

merged 6 commits into from
Jul 7, 2020

Conversation

kcajmagic
Copy link
Member

No description provided.

@kcajmagic kcajmagic requested a review from joe94 July 6, 2020 21:14
@codecov
Copy link

codecov bot commented Jul 6, 2020 •
edited

Codecov Report

Merging #168 into master will decrease coverage by 3.99%.
The diff coverage is 54.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #168      +/-   ##
==========================================
- Coverage   77.24%   73.24%   -4.00%     
==========================================
  Files          11       13       +2     
  Lines         435      527      +92     
==========================================
+ Hits          336      386      +50     
- Misses         93      127      +34     
- Partials        6       14       +8
Impacted Files Coverage Δ
hooks/mocks.go 54.54% <54.54%> (ø)
hooks/hooks.go 54.32% <55.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4b5d54...baac546. Read the comment docs.

joe94
joe94 requested changes Jul 7, 2020
View reviewed changes
go.mod Outdated Show resolved Hide resolved
deploy/packaging/tr1d1um_spruce.yaml Outdated Show resolved Hide resolved
tr1d1um.yaml Show resolved Hide resolved
hooks/hooks.go Outdated Show resolved Hide resolved
tr1d1um.yaml Outdated Show resolved Hide resolved
hooks/hooks.go Show resolved Hide resolved
@joe94 joe94 added this to In progress in XMiDT via automation Jul 7, 2020
@joe94 joe94 added the road-to-argus Issues to be solved for the switch to argus label Jul 7, 2020
@kcajmagic kcajmagic requested a review from joe94 July 7, 2020 16:11
joe94
joe94 approved these changes Jul 7, 2020
View reviewed changes
Copy link
Member

@joe94 joe94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

XMiDT automation moved this from In progress to PRs: Approved Jul 7, 2020
@kcajmagic kcajmagic merged commit 9396233 into xmidt-org:master Jul 7, 2020
XMiDT automation moved this from PRs: Approved to Done Jul 7, 2020
@kcajmagic kcajmagic deleted the feature/argus branch July 7, 2020 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe94 joe94 joe94 approved these changes

Assignees

@kcajmagic kcajmagic

Labels
road-to-argus Issues to be solved for the switch to argus
Projects
XMiDT
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kcajmagic @joe94