Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copr spec file parser does not like '%S' #178

Merged
merged 3 commits into from
Nov 10, 2020
Merged

Copr spec file parser does not like '%S' #178

merged 3 commits into from
Nov 10, 2020

Conversation

joe94
Copy link
Member

@joe94 joe94 commented Nov 9, 2020

Debugging why copr builds are failing:

Writing config into /tmp/copr-rpmbuild-algqo_4b/obtain-sources/.config/rpkg.conf
Running: rpkg srpm --outdir /tmp/copr-rpmbuild-algqo_4b --spec /tmp/copr-rpmbuild-algqo_4b/obtain-sources/tr1d1um/deploy/packaging/tr1d1um.spec

cmd: ['rpkg', 'srpm', '--outdir', '/tmp/copr-rpmbuild-algqo_4b', '--spec', '/tmp/copr-rpmbuild-algqo_4b/obtain-sources/tr1d1um/deploy/packaging/tr1d1um.spec']
cwd: /tmp/copr-rpmbuild-algqo_4b/obtain-sources/tr1d1um
rc: 0
stdout: Wrote: /tmp/copr-rpmbuild-algqo_4b/tr1d1um.spec
stderr: error: /tmp/copr-rpmbuild-algqo_4b/tr1d1um.spec: line 29: %S: argument expected
can't parse specfile

Output: ['tr1d1um.spec']

@joe94 joe94 marked this pull request as draft November 9, 2020 23:23
@codecov
Copy link

codecov bot commented Nov 9, 2020

Codecov Report

Merging #178 (578ed11) into main (47aa1be) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #178   +/-   ##
=======================================
  Coverage   76.30%   76.30%           
=======================================
  Files          11       11           
  Lines         384      384           
=======================================
  Hits          293      293           
  Misses         84       84           
  Partials        7        7           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47aa1be...578ed11. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Nov 10, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@joe94
Copy link
Member Author

joe94 commented Nov 10, 2020

I verified the version of the date command matches the one we expect.

date --version
date (GNU coreutils) 8.22
Copyright (C) 2013 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>.
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Written by David MacKenzie.

So this tells me that their .spec file parser changed somehow.

@joe94
Copy link
Member Author

joe94 commented Nov 10, 2020

@kcajmagic, what do you think about switching to this format:

date -u '+%c'
Tue 10 Nov 2020 12:07:37 AM UTC

It works fine on copr and it contains all the info we want.

@joe94 joe94 marked this pull request as ready for review November 10, 2020 00:22
@joe94 joe94 requested a review from kcajmagic November 10, 2020 00:23
@joe94 joe94 self-assigned this Nov 10, 2020
@joe94 joe94 changed the title test copr Copr spec file parser does not like '%S' Nov 10, 2020
@joe94 joe94 merged commit efc88b8 into main Nov 10, 2020
@joe94 joe94 deleted the bugfix/coprBuild branch November 10, 2020 18:54
@joe94 joe94 mentioned this pull request Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants