Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use context with trace for outgoing requests #211

Merged
merged 3 commits into from
May 19, 2021
Merged

Conversation

joe94
Copy link
Member

@joe94 joe94 commented May 19, 2021

No description provided.

@joe94 joe94 linked an issue May 19, 2021 that may be closed by this pull request
@codecov
Copy link

codecov bot commented May 19, 2021

Codecov Report

Merging #211 (919442d) into main (149d3e1) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 919442d differs from pull request most recent head 263fed3. Consider uploading reports for the commit 263fed3 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #211   +/-   ##
=======================================
  Coverage   76.03%   76.03%           
=======================================
  Files          11       11           
  Lines         388      388           
=======================================
  Hits          295      295           
  Misses         87       87           
  Partials        6        6           
Impacted Files Coverage Δ
stat/service.go 84.61% <100.00%> (ø)
translation/service.go 80.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 149d3e1...263fed3. Read the comment docs.

@Sachin4403
Copy link
Contributor

Hi @joe94 we need to fix this in /hook and /hooks endpoint too.

@joe94 joe94 marked this pull request as ready for review May 19, 2021 19:52
@joe94 joe94 merged commit b260071 into main May 19, 2021
@joe94 joe94 deleted the bugfix/contextTrace branch May 19, 2021 19:54
@sonarcloud
Copy link

sonarcloud bot commented May 19, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

40.0% 40.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tr1d1um is not forwarding the TraceInformation to downstream services.
2 participants