Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unexport logger getter and setter #219

Merged
merged 2 commits into from
Jun 11, 2021
Merged

Unexport logger getter and setter #219

merged 2 commits into from
Jun 11, 2021

Conversation

joe94
Copy link
Member

@joe94 joe94 commented Jun 10, 2021

No description provided.

@joe94 joe94 changed the title keep setter and getter unexported Unexport logger getter and setter Jun 10, 2021
@codecov
Copy link

codecov bot commented Jun 10, 2021 •
edited
Loading

Codecov Report

Merging #219 (1d20883) into main (23e1cb9) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #219   +/-   ##
=======================================
  Coverage   45.00%   45.00%           
=======================================
  Files          13       13           
  Lines         671      671           
=======================================
  Hits          302      302           
  Misses        363      363           
  Partials        6        6
Impacted Files Coverage Δ
basculeLogging.go 43.75% <ø> (ø)
main.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23e1cb9...1d20883. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Jun 10, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

kristinapathak
kristinapathak approved these changes Jun 10, 2021
View reviewed changes
Copy link
Contributor

@kristinapathak kristinapathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call

@joe94 joe94 merged commit df106dc into main Jun 11, 2021
@joe94 joe94 deleted the hotfix/consistentNaming branch June 11, 2021 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristinapathak kristinapathak kristinapathak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joe94 @kristinapathak