-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
passing getlogger to errorencoder on ancla level #233
Conversation
Codecov Report
@@ Coverage Diff @@
## main #233 +/- ##
==========================================
+ Coverage 46.17% 46.50% +0.32%
==========================================
Files 13 13
Lines 758 772 +14
==========================================
+ Hits 350 359 +9
- Misses 400 404 +4
- Partials 8 9 +1
Continue to review full report at Codecov.
|
fixes xmidt-org/ancla#89 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Left a few suggestions and questions.
CHANGELOG.md
Outdated
@@ -5,6 +5,10 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) | |||
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html). | |||
|
|||
## [Unreleased] | |||
- Bumped argus to v0.6.0. [#233](https://github.com/xmidt-org/tr1d1um/pull/233) | |||
- Bumped ancla to v0.3.5: | |||
- Changed server log source address field. [#231](https://github.com/xmidt-org/tr1d1um/pull/231) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was right - this was already released in the previous version.
SonarCloud Quality Gate failed. |
No description provided.