Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

passing getlogger to errorencoder on ancla level #233

Merged
merged 9 commits into from
Dec 1, 2021
Merged

Conversation

mtrinh11
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Nov 29, 2021

Codecov Report

Merging #233 (1b94ada) into main (69f5cd7) will increase coverage by 0.32%.
The diff coverage is 60.00%.

❗ Current head 1b94ada differs from pull request most recent head 8f931b0. Consider uploading reports for the commit 8f931b0 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #233      +/-   ##
==========================================
+ Coverage   46.17%   46.50%   +0.32%     
==========================================
  Files          13       13              
  Lines         758      772      +14     
==========================================
+ Hits          350      359       +9     
- Misses        400      404       +4     
- Partials        8        9       +1     
Impacted Files Coverage Δ
basculeLogging.go 40.00% <ø> (ø)
common/errors.go 100.00% <ø> (ø)
common/transactor.go 100.00% <ø> (ø)
main.go 0.00% <0.00%> (ø)
stat/transport.go 65.90% <0.00%> (ø)
translation/transport.go 88.43% <0.00%> (ø)
common/utils.go 59.78% <85.71%> (+2.99%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69f5cd7...8f931b0. Read the comment docs.

@mtrinh11
Copy link
Contributor Author

fixes xmidt-org/ancla#89

Copy link
Contributor

@kristinapathak kristinapathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Left a few suggestions and questions.

CHANGELOG.md Outdated Show resolved Hide resolved
common/utils.go Outdated Show resolved Hide resolved
common/utils.go Outdated Show resolved Hide resolved
common/utils_test.go Outdated Show resolved Hide resolved
CHANGELOG.md Outdated
@@ -5,6 +5,10 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

## [Unreleased]
- Bumped argus to v0.6.0. [#233](https://github.com/xmidt-org/tr1d1um/pull/233)
- Bumped ancla to v0.3.5:
- Changed server log source address field. [#231](https://github.com/xmidt-org/tr1d1um/pull/231)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was right - this was already released in the previous version.

@mtrinh11 mtrinh11 merged commit aba8ded into main Dec 1, 2021
@mtrinh11 mtrinh11 deleted the getlogger branch December 1, 2021 19:33
@sonarcloud
Copy link

sonarcloud bot commented Dec 1, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

61.1% 61.1% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants