Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separated main.go and created primaryHandler.go #239

Merged
merged 3 commits into from
Dec 30, 2021
Merged

Conversation

mtrinh11
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Dec 30, 2021

Codecov Report

Merging #239 (7283d2e) into main (82f8322) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #239   +/-   ##
=======================================
  Coverage   47.57%   47.57%           
=======================================
  Files          11       12    +1     
  Lines         763      763           
=======================================
  Hits          363      363           
  Misses        391      391           
  Partials        9        9           
Impacted Files Coverage Δ
main.go 0.00% <ø> (ø)
primaryHandler.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82f8322...7283d2e. Read the comment docs.

@mtrinh11
Copy link
Contributor Author

fixes #237

Copy link
Contributor

@kristinapathak kristinapathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one small copyright change.

main.go Show resolved Hide resolved
}

// JWTValidator provides a convenient way to define jwt validator through config files
type JWTValidator struct {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All structs at the top of the file looks good. 👍

@sonarcloud
Copy link

sonarcloud bot commented Dec 30, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@mtrinh11 mtrinh11 merged commit 84448b2 into main Dec 30, 2021
@mtrinh11 mtrinh11 deleted the separateMain branch December 30, 2021 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants