-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FR: Support Alternate Server #297
Conversation
Codecov Report
@@ Coverage Diff @@
## main #297 +/- ##
==========================================
- Coverage 44.31% 43.61% -0.70%
==========================================
Files 15 15
Lines 1126 1144 +18
==========================================
Hits 499 499
- Misses 619 637 +18
Partials 8 8
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good first pass! there's a few things we should tweak that we can talk about next week. you don't need to name as many components, since injection by type is simpler and works where there's only one component of a type.
What's included