Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Support Alternate Server #297

Merged
merged 6 commits into from
Sep 1, 2022

Conversation

denopink
Copy link
Contributor

What's included

  • Support for an alternate server

@denopink denopink self-assigned this Aug 30, 2022
@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Merging #297 (026694a) into main (c603e58) will decrease coverage by 0.69%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #297      +/-   ##
==========================================
- Coverage   44.31%   43.61%   -0.70%     
==========================================
  Files          15       15              
  Lines        1126     1144      +18     
==========================================
  Hits          499      499              
- Misses        619      637      +18     
  Partials        8        8              
Flag Coverage Δ
unittests 43.61% <0.00%> (-0.70%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
routes.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

routes.go Outdated Show resolved Hide resolved
routes.go Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Aug 31, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@johnabass johnabass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good first pass! there's a few things we should tweak that we can talk about next week. you don't need to name as many components, since injection by type is simpler and works where there's only one component of a type.

@denopink denopink merged commit aca22df into main Sep 1, 2022
@denopink denopink deleted the denopink/feature/support-alternate-server branch September 1, 2022 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants