Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Fix Metric Server #331

Merged
merged 4 commits into from
Nov 8, 2022
Merged

Bug: Fix Metric Server #331

merged 4 commits into from
Nov 8, 2022

Conversation

denopink
Copy link
Contributor

@denopink denopink commented Nov 7, 2022

What's included:

closes #329

@denopink denopink added bug webpa-common archival/deprecation work related to the archival & deprecation of webpa-common labels Nov 7, 2022
@denopink denopink self-assigned this Nov 7, 2022
@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Merging #331 (2fdadec) into main (7a23d23) will decrease coverage by 0.15%.
The diff coverage is 0.00%.

❗ Current head 2fdadec differs from pull request most recent head fdf4a95. Consider uploading reports for the commit fdf4a95 to get more accurate results

@@            Coverage Diff             @@
##             main     #331      +/-   ##
==========================================
- Coverage   44.67%   44.51%   -0.16%     
==========================================
  Files          15       15              
  Lines        1117     1121       +4     
==========================================
  Hits          499      499              
- Misses        610      614       +4     
  Partials        8        8              
Flag Coverage Δ
unittests 44.51% <0.00%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
routes.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Nov 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Member

@renaz6 renaz6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@denopink denopink merged commit 703d725 into main Nov 8, 2022
@denopink denopink deleted the denopink/patch/fx-prometheus branch November 8, 2022 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug webpa-common archival/deprecation work related to the archival & deprecation of webpa-common
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No Prom Metrics Being Produced
2 participants