Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Denopink/patch/fx integration error #335

Merged
merged 10 commits into from
Nov 11, 2022
Merged

Conversation

denopink
Copy link
Contributor

@denopink denopink commented Nov 8, 2022

@denopink denopink added the bug label Nov 8, 2022
@denopink denopink self-assigned this Nov 8, 2022
stat/transport.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Merging #335 (a93b74e) into main (09718ba) will decrease coverage by 0.35%.
The diff coverage is 79.06%.

@@            Coverage Diff             @@
##             main     #335      +/-   ##
==========================================
- Coverage   44.51%   44.15%   -0.36%     
==========================================
  Files          15       15              
  Lines        1121     1130       +9     
==========================================
  Hits          499      499              
- Misses        614      620       +6     
- Partials        8       11       +3     
Flag Coverage Δ
unittests 44.15% <79.06%> (-0.36%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
translation/transport.go 84.75% <55.00%> (-4.14%) ⬇️
stat/transport.go 75.00% <100.00%> (+0.35%) ⬆️
transaction/errors.go 89.28% <100.00%> (-0.37%) ⬇️
transaction/transactor.go 91.25% <100.00%> (+1.39%) ⬆️
translation/transport_utils.go 83.19% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Nov 11, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

86.1% 86.1% Coverage
0.0% 0.0% Duplication

@denopink denopink merged commit 424a41d into main Nov 11, 2022
@denopink denopink deleted the denopink/patch/fx-integration-error branch November 11, 2022 18:26
@denopink denopink restored the denopink/patch/fx-integration-error branch November 11, 2022 18:26
@denopink denopink deleted the denopink/patch/fx-integration-error branch November 11, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants