Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracing Header Patch #389

Merged
merged 3 commits into from
Mar 2, 2023
Merged

Tracing Header Patch #389

merged 3 commits into from
Mar 2, 2023

Conversation

renaz6
Copy link
Member

@renaz6 renaz6 commented Mar 2, 2023

  • Realized I used tracestatus instead of the correct W3C standard header, tracestate. This has been corrected.
  • Validated that traceparent can exist without a tracestate but not vice versa. We decided that if a tracestate is not passed, we will still set the tracestate header in WRP with an empty value. The logic has been updated to match these discoveries/decisions.

@renaz6 renaz6 self-assigned this Mar 2, 2023
@codecov
Copy link

codecov bot commented Mar 2, 2023

Codecov Report

Merging #389 (e0d23f1) into main (9dcf2a6) will increase coverage by 0.12%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##             main     #389      +/-   ##
==========================================
+ Coverage   44.10%   44.22%   +0.12%     
==========================================
  Files          15       15              
  Lines        1136     1135       -1     
==========================================
+ Hits          501      502       +1     
+ Misses        622      621       -1     
+ Partials       13       12       -1     
Flag Coverage Δ
unittests 44.22% <40.00%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
translation/transport.go 83.12% <40.00%> (+0.76%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Mar 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

40.0% 40.0% Coverage
0.0% 0.0% Duplication

@renaz6 renaz6 merged commit 5e2e3b8 into main Mar 2, 2023
@renaz6 renaz6 deleted the tracingHeaderPatch branch March 2, 2023 17:41
@renaz6 renaz6 mentioned this pull request Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants