Add a structured log field for just the normalized device-id. #391
Conversation
…e id from url path
transaction/transactor.go
Outdated
| id, ok := vars["deviceid"] | ||
| if !ok { | ||
| //TODO: edit log statement | ||
| fmt.Println("id is missing in parameters") |
There was a problem hiding this comment.
If the id isn't present I think we should add a deviceid of mac:000000000000 which is both a valid address, but also a reserved value that should never be used. This will allow us to track this happened easier than nothing being present.
There was a problem hiding this comment.
I'm not sure how difficult it would be to make this configurable (ideal).
Codecov Report
@@ Coverage Diff @@
## main #391 +/- ##
==========================================
+ Coverage 44.22% 45.14% +0.91%
==========================================
Files 15 15
Lines 1135 1154 +19
==========================================
+ Hits 502 521 +19
Misses 621 621
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Co-authored-by: Owen Cabalceta <denopink@gmail.com>
Co-authored-by: Owen Cabalceta <denopink@gmail.com>
Co-authored-by: Owen Cabalceta <denopink@gmail.com>
|
Kudos, SonarCloud Quality Gate passed! |
What's included: #373