Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for libxml2 version 2.10.2 #192

Closed

Conversation

martijnbolhuis
Copy link

  • Add include for xlink.h to solve compilation error unknown type name ‘xlinkType’. See commit ebb17970 ("Remove unneeded #includes") in the libxml2 source code which removed this include.
  • FTP support and legacy modules have been disabled by default (see commit 776b0028 in libxml2). The test was updated accordingly.
  • Docbook has been disabled by default (see commit aeaf02c0 in libxml2). The test was updated accordingly.

- Add include for `xlink.h` to solve compilation error `unknown type name
  ‘xlinkType’`. See commit `ebb17970` ("Remove unneeded #includes") in the
  libxml2 source code which removed this include.
- FTP support and legacy modules have been disabled by default (see commit
  `776b0028` in libxml2). The test was updated accordingly.
- Docbook has been disabled by default (see commit `aeaf02c0` in libxml2). The
  test was updated accordingly.
@martijnbolhuis
Copy link
Author

Hi,

I am unable to install libxml-ruby on Arch Linux since libxml2 has been updated to version 2.10.2. I got the following error during compilation. This was also reported in this bug

ruby_xml_node.c:792:3: error: unknown type name ‘xlinkType’

I've tried to fix this problem but I'm not very familiar with C-programming. All errors and failing test can be explained from changes in the libxml2 library (see my commit message). Compilation seems to work (rake compile) and the test run successfully. Please have a look if these changes make sense.

Kind regards,
Martijn

@cfis
Copy link
Member

cfis commented Oct 15, 2022

Can this file just be included in ruby_xml_node.c then?

@pulver
Copy link

pulver commented Oct 16, 2022

Can this file just be included in ruby_xml_node.c then?

Yes. I'm on arch linux and encountered the same error. I fixed it locally by adding #include <libxml/xlink.h> to ext/libxml/ruby_xml_node.c only.

@cfis
Copy link
Member

cfis commented Oct 17, 2022

I can verify that. Closing this PR in favor of a less invasive change.

@cfis cfis closed this Oct 17, 2022
@vtamara
Copy link

vtamara commented Oct 27, 2022

I have the same issue on OpenBSD/adJ 7.2.

@itay-grudev
Copy link

@cfis What is the less invasive change? Is there any progress on this?

@cfis
Copy link
Member

cfis commented Jan 17, 2023

Did you try the latest version? 4.0.0? Should be fixed there. If not let me know.

@vtamara
Copy link

vtamara commented Jan 17, 2023

Did you try the latest version? 4.0.0? Should be fixed there. If not let me know.

It worked for me. Thank you.

@cfis
Copy link
Member

cfis commented Jan 17, 2023

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants