Adding full pass-through support for underlying libxml2 function #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * segfault when using XML_C14N_EXCLUSIVE_1_0 mode. | ||
| * API docs: "list of inclusive namespace prefixes ended with a NULL" | ||
| */ | ||
| inc_ns_prefixes_ptr[0] = NULL; |
There was a problem hiding this comment.
irb will throw a fit and segfault if this is not used.
cfis
added a commit
that referenced
this pull request
Mar 18, 2012
Adding full pass-through support for underlying libxml2 function
|
Hi Ryan, Sorry it took me so long to get to this. Patch looks great, will cut a new release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide full pass-through for libxml2 function "xmlC14NDocDumpMemory" with support for optional hash arguments. (In response to Issue #36 with xml4r/libxml-ruby.)