Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

downgrade ruby version dependency #12

Merged
merged 5 commits into from
Oct 14, 2014

Conversation

sshao
Copy link
Contributor

@sshao sshao commented Oct 7, 2014

Downgrade ruby version dependency

In commit d9b59ff, required_ruby_version was changed from 1.8.6 to 1.9.3. However, I was able to successfully build and run the specs (rake compile && rake test) on ruby 1.8.7p358 (OSX 10.9.5).

Likewise, gem build libxslt-ruby.gemspec && gem install libxslt-ruby-1.1.1.gem successfully installed the gem on ruby 1.8.7, although parsing documentation failed: rdoc/rdoc#327

Update Rakefile

Additionally, the rake:rdoc task expects to find a README file. It instead needs to search for the README.rdoc file.

Changed "README" -> "README.rdoc".
@cfis
Copy link
Member

cfis commented Oct 8, 2014

Ruby 1.8.7 was end-of-lifed a year ago, so its no longer supported by this gem.

@sshao
Copy link
Contributor Author

sshao commented Oct 8, 2014

Are there technical reasons why it can't be supported? MRI 1.8.7 was EOL'd, but it's still being used (redhat continues to support 1.8.7 in RHEL), and Rubinius 1.3.4 (and as far as I know JRuby as well) both support 1.8.7; apps running on those could want to use libxslt-ruby.

@cfis
Copy link
Member

cfis commented Oct 13, 2014

There probably aren't any technical reasons, outside of its never tested anymore. JRuby wouldn't use libxslt-ruby since its a C extension, and no one has ever asked about Rubinius that I can recall.

So I just don't see any point to it.

@sshao
Copy link
Contributor Author

sshao commented Oct 13, 2014

This (in addition to my first PR) would actually allow a project I'm working on to use the latest version of libxslt-ruby on Rubinius 1.3.

@sshao
Copy link
Contributor Author

sshao commented Oct 13, 2014

Also, a passing Travis build on 1.8.7. I can't test this branch on rbx-1.3 right now because #11 causes the compilation step to fail on Travis, and I have to use rake compile:libxslt_ruby as the previously mentioned rdoc issue crops up in rake compile.

cfis added a commit that referenced this pull request Oct 14, 2014
@cfis cfis merged commit 933c94b into xml4r:master Oct 14, 2014
@sshao sshao deleted the 1.1.1/downgrade_ruby_version_dependency branch November 24, 2014 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants