Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep lint in separate GitHub action #111

Closed
brodybits opened this issue Aug 19, 2020 · 0 comments · Fixed by #297 or #304
Closed

keep lint in separate GitHub action #111

brodybits opened this issue Aug 19, 2020 · 0 comments · Fixed by #297 or #304

Comments

@brodybits
Copy link
Member

idea from @karfau

Prettier does this, and I think it would help people see more quickly whether a build failure comes from lint or from a test failure.

karfau added a commit that referenced this issue Aug 23, 2021
To fix #111 I think it's good enough to split test and lint into two different build steps.
Separate actions are not required since the github actions details view now shows what steps failed.

To be able to do that split, I needed to drop the execution of the `lint` script from the `test` script. The `start` script still runs both in watch mode, so it's still easy to run both when developing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant