Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixed line endings in the repo #56

Closed
karfau opened this issue Jun 22, 2020 · 0 comments · Fixed by #66
Closed

Mixed line endings in the repo #56

karfau opened this issue Jun 22, 2020 · 0 comments · Fixed by #66

Comments

@karfau
Copy link
Member

karfau commented Jun 22, 2020

There are 18 files that contain CRLF line endings/ line separators/ line breaks in them:

I found this out the hard way by having huge diffs in #51 .

To detect them I downloaded the zip archive of the repo (to circum went changes git does when checking out code), opened the unzipped folder in my IDE and ran the related inspection "Inconsistent line separators" on the whole folder structure:

test/3rd-cases/o3xml.js
test/parse/namespace.js
test/parse/node.js
test/parse/big-file-performance.js
test/parse/simple.js
test/parse/parse-element.js
test/parse/locator.js
test/error/xml-error.js
test/error/error.js
test/html/normalize.js
test/dom/attr.js
test/dom/element.js
test/dom/level3.js
test/dom/clone.js
test/dom/index.js
test/test.js
test/index.js
__package__.js

Ideally even when people from different OSes contribute the repo should only contain LF line endings,
for the git config option core.autocrlf to work properly.

This can be enforced by adding a .gitattributes and/or .editorconfig file into the repo.

karfau added a commit to karfau/xmldom that referenced this issue Jun 28, 2020
This just converts the files, no enforcement yet

fixes xmldom#56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant