Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure Renovate #108

Merged
merged 9 commits into from
Aug 17, 2020
Merged

Configure Renovate #108

merged 9 commits into from
Aug 17, 2020

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 17, 2020

Welcome to Renovate! This is an onboarding PR to help you understand and configure settings before regular Pull Requests begin.

🚦 To activate Renovate, merge this Pull Request. To disable Renovate, simply close this Pull Request unmerged.


Detected Package Files

  • package.json (npm)

Configuration

🔡 Renovate has detected a custom config for this PR. Feel free to ask for help if you have any doubts and would like it reviewed.

Important: Now that this branch is edited, Renovate can't rebase it from the base branch any more. If you make changes to the base branch that could impact this onboarding PR, please merge them manually.

What to Expect

With your current configuration, Renovate will create 1 Pull Request:

Update stryker monorepo -> ^3.3.1 - devDependencies

❓ Got questions? Check out Renovate's Docs, particularly the Getting Started section.
If you need any further assistance then you can also request help here.


This PR has been generated by WhiteSource Renovate. View repository job log here.

@karfau
Copy link
Member

karfau commented Aug 17, 2020

Maybe you want to use https://docs.renovatebot.com/presets-config/#configjs-lib ?
But how ever you decide, very happy about this development.

@brodybits
Copy link
Member

Maybe you want to use https://docs.renovatebot.com/presets-config/#configjs-lib ?

Tried it, think I want to back it out unfortunately.

The what to expect section now shows me that it wants to pin dependencies, even though I am using "rangeStrategy": "bump" which should avoid this: https://github.com/renovatebot/renovate/blob/master/docs/usage/configuration-options.md#rangestrategy

to avoid extra pinning with `"rangeStrategy": "bump"`
renovate.json Outdated Show resolved Hide resolved
brodybits and others added 3 commits August 17, 2020 17:13
Co-authored-by: Eric Newport <kethinov@gmail.com>
Comment on lines +4 to +6
":preserveSemverRanges",
":ignoreUnstable",
":respectLatest",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor question but I do not really understand the benefits of these lines by @kethinov.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's been a while since I researched these for other projects, but if I recall correctly we adopted the rules for the following reasons:

  • preserveSemverRanges: Prevents it from rewriting your dependencies from ~ to ^ or vice versa so you can pin them to whatever degree of specificity you like.
  • ignoreUnstable: Allows Renovate to bump beta/pre-release dependencies if you opt-in to any and will not bump them if the existing version is not already an unstable version.
  • respectLatest: Similar to above. Will not upgrade to anything on npm that isn't tagged with "latest."

@brodybits
Copy link
Member

I would like to merge this now to unblock PR #105. Any more comments from @kethinov or @karfau?

@brodybits brodybits mentioned this pull request Aug 17, 2020
@brodybits brodybits dismissed kethinov’s stale review August 17, 2020 21:44

resolved by applying the additional settings as recommended

@brodybits brodybits merged commit b935c84 into master Aug 17, 2020
@brodybits brodybits deleted the renovate/configure branch August 17, 2020 21:48
@brodybits
Copy link
Member

Thanks @kethinov for the quick feedback & review!

I did clean up the merge commit a little but kept more info than usual with what I think are some nice, valuable links to the Renovate docs which I do not always find super easy to navigate and search through :)

This was referenced Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants