-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: preserve doctype with sysid (#143) #144
Conversation
@karfau do you think we want to include this in the upcoming 0.4.0 release? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Thx a lot.
(@davidmc24 I took the liberty to change the PR description, so that it will close the issue when it lands.)
@brodybits I don't see a reason why we shouldn't 👍 |
The one little thing I wonder is if these changes could introduce any more surviving mutants when running Stryker. Unfortunately I have no time to try this now, and I don't think this should be blocking. @karfau it would be great if you can merge this (as a squash commit). Thanks again! |
I'm glad the PR seems to be well received. Thank you for your work maintaining this library. |
@brodybits I tried to run stryker after applying the patch, and have received 8 new mutants, but my scores differ for every file from the one produced by github actions on master. So not sure what to derive from it. I guess we will see the result when it lands. |
Maybe we should investigate which mutations differ in the reports from the command line vs GitHub. |
Fixes #143