feat: Update DOMImplementation according to recent specs
#210
Conversation
karfau
added
documentation
- deprecate `hasFeature` and simplify implementation according to the latest spec - `createDocumentType` sets `publicId` and `systemId` to an empty string instead of `undefined` - `createDocument` sets `docType` to `null` instead of `undefined` - export `DocumentType`, `Element`, `Node` and `NodeList` to verify instanceof in tests
karfau
changed the title
DOMImplementation against (latest) specs
| function DOMImplementation(/* Object */ features) { | ||
| this._features = {}; | ||
| if (features) { | ||
| for (var feature in features) { | ||
| this._features = features[feature]; | ||
| } | ||
| } | ||
| }; |
There was a problem hiding this comment.
The previous implementation left the definition of features and versions that are supported to the code that calls the constructor, which doesn't make any sense at all. This was one more reason why I decided to not keep or fix it, but to implement it as it is specified in the living standard.
brodybits
changed the title
DOMImplementation against (latest) specsDOMImplementation according to recent specs
| Element, | ||
| Node, | ||
| NodeList, | ||
| } = require('../../lib/dom') |
There was a problem hiding this comment.
I would favor that we export and use these from lib/index.js, as I proposed in PR #233.
There was a problem hiding this comment.
Does it mean you want to land #233 first? Since lib/index.js doesn't exist on master yet.
It currently already has a conflict and I raised two questions there.
If you think it's important to solve this before anything else, let's focus on that issue.
If not I would prefer to leave this as is in this PR, land it and continue to solve that issue in the related PR.
- deprecate `hasFeature` and simplify implementation according to the latest spec - `createDocumentType` sets `publicId` and `systemId` to an empty string instead of `undefined` - `createDocument` sets `docType` to `null` instead of `undefined` - export `DocumentType`, `Element`, `Node` and `NodeList` to verify `instanceof` in tests - update doc comments with links to specs and type information
hasFeatureand simplify implementation according to the latest speccreateDocumentTypesetspublicIdandsystemIdto an empty string instead ofundefinedcreateDocumentsetsdocTypetonullinstead ofundefinedDocumentType,Element,NodeandNodeListto verifyinstanceofin testsThis PR is part of the preparation for solving #203