-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Set localName
as part of Document.createElement
#229
Conversation
This seemed to be missing. Without it, xpath (XPath 1.0) works, but xpath2 (XPath 2.0) and fontoxpath (XPath 3.x) do not match elements.
localName
as part of Document.createElement
I just checked, the property I also checked that we are already and in all cases setting this field as part of @rrthomas Thank you for the PR, are you able to add some minimal test(s) to |
Thanks for the analysis (I'm not an expert in this area, so didn't venture to go further on my own!). I'll see if I can add a test. |
87dff25
to
9135062
Compare
Thank you for your contribution, it will be part of the next release. |
Co-authored-by: Christian Bewernitz <coder@karfau.de>
This seemed to be missing. Without it, xpath (XPath 1.0) works, but
xpath2 (XPath 2.0) and fontoxpath (XPath 3.x) do not match elements.