Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): Add index.d.ts to packaged files #288

Merged
merged 2 commits into from
Aug 20, 2021

Conversation

forty
Copy link
Contributor

@forty forty commented Aug 20, 2021

Sorry, I did not notice earlier. Looks like we will need a 0.7.2 😬

@kachkaev
Copy link
Contributor

kachkaev commented Aug 20, 2021

Sorry for not spotting this when doing #283 😔

@brodybits brodybits changed the title Add index.d.ts to packaged files fix: Add index.d.ts to packaged files Aug 20, 2021
Copy link
Member

@brodybits brodybits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on my part, with quick update to the title according to conventional commits

(please feel free to change it again if you like)

left a suggestion just from my personal preference

leaving up to @karfau for the next steps

package.json Outdated Show resolved Hide resolved
Co-authored-by: Chris Brody <git.brodybits@gmail.com>
@karfau karfau changed the title fix: Add index.d.ts to packaged files fix(types): Add index.d.ts to packaged files Aug 20, 2021
@karfau karfau added bug Something isn't working types Anything regarding Typescript and removed bug Something isn't working labels Aug 20, 2021
@karfau
Copy link
Member

karfau commented Aug 20, 2021

Damn, I planned to double check exactly that, but forgot about it.
Thx for providing the fix.

Will proceed to release it

@karfau karfau merged commit 284a019 into xmldom:master Aug 20, 2021
@kachkaev
Copy link
Contributor

0.7.2 works perfectly 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
types Anything regarding Typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants