test(api): fix nest api linting and testing

PLAYBOOK-NEST.md

@@ -59,8 +59,6 @@ npm i -D @types/helmet
 
 #### Generate Artifacts
 ```bash
-cd apps/api
-
 # scaffold core module
 nest g module core --dry-run
 nest g guard auth core --dry-run

angular.json

@@ -128,7 +128,7 @@
                   "baseline": "10mb",
                   "maximumError": "20%",
                   "maximumWarning": "10%"
-                },
+                }
               ]
             },
             "mock": {
@@ -225,6 +225,32 @@
         }
       }
     },
+    "api": {
+      "root": "apps/api",
+      "sourceRoot": "apps/api/src",
+      "projectType": "application",
+      "architect": {
+        "lint": {
+          "builder": "@angular-devkit/build-angular:tslint",
+          "options": {
+            "tsConfig": [
+              "apps/api/tsconfig.json",
+              "apps/api/tsconfig.spec.json"
+            ],
+            "exclude": [
+              "**/node_modules/**"
+            ]
+          }
+        },
+        "test": {
+          "builder": "@nrwl/builders:jest",
+          "options": {
+            "jestConfig": "apps/api/jest.config.js",
+            "tsConfig": "apps/api/tsconfig.spec.json"
+          }
+        }
+      }
+    },
     "navigator": {
       "root": "libs/navigator",
       "sourceRoot": "libs/navigator/src",

apps/api/README.md

@@ -86,7 +86,6 @@ npm run api:webpack -- -p
 # check of nest installed
 nest info
 
-cd apps/api
 # scaffold project module
 nest generate module project --dry-run
 nest generate controller project --dry-run
@@ -100,23 +99,16 @@ nest g exception auth --dry-run
 ```
 
 ### Test
-> coverage will be generate in dist/api/coverage
+> coverage will be generate in coverage/apps/api
 ```bash
 # unit tests
 npm run api:test
-# for api project
-npx jest --projects=apps/api --roots=src
-
-
-# e2e tests
-npm run api:test:e2e
-# for api project
-npx jest --projects=apps/api --roots=e2e
 
 # test coverage
 npm run api:test:cov
-# for api project
-npx jest --projects=apps/api --coverage
+
+# e2e tests
+npm run api:e2e
 ```
 
 

apps/api/e2e/app.e2e-spec.ts

@@ -21,4 +21,8 @@ describe('AppController (e2e)', () => {
       .expect(200)
       .expect(/Welcome to Sumo API/);
   });
+
+  afterAll(async () => {
+    await app.close();
+  });
 });

apps/api/jest.config.js

@@ -1,5 +1,5 @@
-const jestBase = require('../../jest.config.base.js');
 module.exports = {
-  ...jestBase,
-  "coverageDirectory": "../../dist/apps/api/coverage",
+  name: 'api',
+  preset: '../../jest.config.nest.js',
+  "coverageDirectory": "../../coverage/apps/api",
 };

apps/api/src/app.controller.spec.ts

@@ -1,15 +1,15 @@
 import { Test, TestingModule } from '@nestjs/testing';
 
 import { AppController } from './app.controller';
-import { CoreModule } from './core';
+import { ConfigModule } from './config';
 
 describe('AppController', () => {
   let app: TestingModule;
 
   beforeAll(async () => {
     app = await Test.createTestingModule({
       controllers: [AppController],
-      imports: [CoreModule],
+      imports: [ConfigModule.forRoot()],
     }).compile();
   });
 

apps/api/src/config/config.service.ts

@@ -1,6 +1,7 @@
 import { parse, config } from 'dotenv';
 import * as fs from 'fs';
 import { Injectable } from '@nestjs/common';
+// tslint:disable-next-line
 const packageJson = require('../../../../package.json');
 
 @Injectable()

apps/api/src/core/context/request-context.ts

@@ -37,6 +37,7 @@ export class RequestContext {
     const requestContext = RequestContext.currentRequestContext();
 
     if (requestContext) {
+      // tslint:disable-next-line
       const user: any = requestContext.request['user'];
       if (user) {
         return user;
@@ -54,6 +55,7 @@ export class RequestContext {
     const requestContext = RequestContext.currentRequestContext();
 
     if (requestContext) {
+      // tslint:disable-next-line
       return requestContext.request['token'];
     }
 

apps/api/tsconfig.spec.json

@@ -1,16 +1,7 @@
 {
   "extends": "./tsconfig.json",
   "compilerOptions": {
-    "types": [
-      "jest",
-      "node"
-    ]
+    "types": ["jest", "node"]
   },
-  "include": [
-    "**/*.spec.ts",
-    "**/*.d.ts"
-  ],
-  "exclude": [
-    "node_modules"
-  ]
+  "include": ["**/*.spec.ts", "**/*.d.ts"]
 }

jest.config.nest.js

@@ -0,0 +1,10 @@
+module.exports = {
+  "moduleFileExtensions": ["js", "json", "ts"],
+  "testRegex": ".spec.ts$",
+  "transform": {
+    "^.+\\.(t|j)s$": "ts-jest"
+  },
+  collectCoverage: true,
+  coverageReporters: ['html'],
+  "testEnvironment": "node"
+};

libs/home/src/lib/containers/about/about.component.ts

@@ -3,7 +3,6 @@ import { ROUTE_ANIMATIONS_ELEMENTS } from '@ngx-starter-kit/animations';
 // import * as Trianglify from 'trianglify';
 declare var Trianglify: any;
 import { fromEvent, Subject, Subscription } from 'rxjs';
-import 'rxjs/add/observable/fromEvent';
 import { map, debounceTime, distinctUntilChanged, takeUntil } from 'rxjs/operators';
 
 @Component({

nest-cli.json

@@ -0,0 +1,5 @@
+{
+  "language": "ts",
+  "collection": "@nestjs/schematics",
+  "sourceRoot": "apps/api/src"
+}

nx.json

@@ -19,6 +19,11 @@
         "webapp"
       ]
     },
+    "api": {
+      "tags": [
+        "api-module"
+      ]
+    },
     "navigator": {
       "tags": [
         "private-module",