Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xmlrunner: Expose python docstrings as comments in the XML result file #214

Merged
merged 2 commits into from
Feb 20, 2020

Conversation

oliviermartin
Copy link
Contributor

These comments could for instance be retrieved by XSLT to add
description to test title.

@coveralls
Copy link

coveralls commented Feb 16, 2020

Coverage Status

Coverage increased (+0.004%) to 99.535% when pulling 3fe2e4b on labapart:add-docstring-to-xml into 67bc432 on xmlrunner:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 99.389% when pulling b79520e on labapart:add-docstring-to-xml into f58d7b7 on xmlrunner:master.

@codecov-io
Copy link

codecov-io commented Feb 16, 2020

Codecov Report

Merging #214 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #214   +/-   ##
=======================================
  Coverage   99.52%   99.53%           
=======================================
  Files          14       14           
  Lines        1482     1490    +8     
=======================================
+ Hits         1475     1483    +8     
  Misses          7        7           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f58d7b7...2ee3ec4. Read the comment docs.

@oliviermartin oliviermartin force-pushed the add-docstring-to-xml branch 2 times, most recently from 5cdaa5e to 2ee3ec4 Compare February 16, 2020 23:24
Copy link
Member

@dnozay dnozay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add positive / negative testcases; and in particular, please cover cases where __doc__ looks like xml.

xmlrunner/result.py Outdated Show resolved Hide resolved
xmlrunner/result.py Outdated Show resolved Hide resolved
@oliviermartin oliviermartin force-pushed the add-docstring-to-xml branch 3 times, most recently from b0c84bc to 37b7809 Compare February 18, 2020 20:48
@oliviermartin
Copy link
Contributor Author

please add positive / negative testcases; and in particular, please cover cases where __doc__ looks like xml.

I added the positive/negative testcases.

As far as I can see the build fails but it is due to HEAD of master being broken.

xmlrunner/result.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants