Add compatibility with xmlsec 1.3 #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
D3X
approved these changes
Sep 17, 2023
PhilipGarnero
approved these changes
Sep 19, 2023
|
@hoefling Would you be the right person to ask regarding running GitHub workflows and getting feedback on this PR? |
|
I can confirm that this PR builds fine on an Apple Silicon machine, and works (at least for my use case, signing SOAP requests). |
|
Can we please fold this in? This has been an issue for quite awhile and the suggested "work-arounds" are no longer feasible. |
This was referenced Nov 28, 2023
Closed
|
On my x86_64 linux machine, I get the following results libxmlsec versions: For the failures: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimal changeset to allow unit tests to pass on both xmlsec 1.2 and 1.3.
This includes disabling the key search strict mode that 1.3 enabled by default, since encrypt/decrypt tests fail without it. In the future, it probably makes sense to enable strict mode by default and provide a method to disable it, but I'm not confident enough in my C skills to build it myself, sorry.
Fixes #254