Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

withComparaisonFormatter not implemented on DiffBuilder #51

Closed
math103 opened this issue Feb 10, 2016 · 4 comments
Closed

withComparaisonFormatter not implemented on DiffBuilder #51

math103 opened this issue Feb 10, 2016 · 4 comments
Milestone

Comments

@math103
Copy link

math103 commented Feb 10, 2016

the method withComparaisonFormatter is not implemented in the DiffBuilder class but the user guide mention it. The user guide should be corrected until the method is really added.

@phbenisc
Copy link
Contributor

Hi @math103,
Hi all,

this statement seems to be true. I also think an implementation would make sense.

Possible Solution would be:

  • implement Method in class DiffBuilder
  • add Contructor argument to class Diff (maybe additional contructor, to be backwards compatible?)
  • add additional class variable to class Diff
  • override toString() Method to use this variable instead of Constant DEFAULT_FORMATTER

other related classes are:
ComparisonFormatter(interface)
DefaultComparisonFormat(class, default Impl)

DiffBuilder doc: here

When the issue gets confirmed I volunteer to implement changes into teh Java Code.

.Net version does also misses this method.

Best Regards,
Philip

@bodewig bodewig added this to the 2.0.0-alpha-05 milestone Feb 11, 2016
@bodewig
Copy link
Member

bodewig commented Feb 11, 2016

I agree it should be there - and probably on CompareMatcher as well.

@bodewig
Copy link
Member

bodewig commented Feb 12, 2016

Implemented with 0259c3d - CompareMatcher already has the withComparisonFormatter method.

I'll close this issue once I've found time to update XMLUnit.NET

@bodewig
Copy link
Member

bodewig commented Feb 12, 2016

fix ported to XMLUnit.NET

@bodewig bodewig closed this as completed Feb 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants