Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve field annotating code to make sure all annotations are added #35

Closed
odrotbohm opened this issue Mar 19, 2021 · 0 comments
Closed

Improve field annotating code to make sure all annotations are added #35

odrotbohm opened this issue Mar 19, 2021 · 0 comments
Assignees
@odrotbohm
Labels
module: bytebuddy ByteBuddy plugin type: enhancement New feature or enhancement to an existing one
Milestone
0.3

Comments

@odrotbohm
Copy link
Member

This shouldn't affect actual production projects but the tests currently cannot properly test for the addition of all annotations as we need to use slightly different code to accumulate multiple annotations on fields (see raphw/byte-buddy#1022 for details).
@odrotbohm odrotbohm added the module: bytebuddy ByteBuddy plugin label Mar 19, 2021
@odrotbohm odrotbohm added this to the 0.3 milestone Mar 19, 2021
@odrotbohm odrotbohm self-assigned this Mar 19, 2021
odrotbohm added a commit that referenced this issue Mar 19, 2021
@odrotbohm
GH-35 - Improve field annotating ByteBuddy code.
bc5650a 
Annotations added to fields are now accumulating. This primarily helps us verifying the build of the plugin itself as it expects both JPA and MongoDB annotations to be added to the sample aggregate root type. In real world projects, it's unlikely that both technologies are used together.
odrotbohm added a commit that referenced this issue Mar 19, 2021
@odrotbohm
GH-35 - Polishing.
8550477 
Simplified OrderId declaration. Formatting in JMoleculesJpaPlugin.
@odrotbohm odrotbohm added the type: enhancement New feature or enhancement to an existing one label Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@odrotbohm odrotbohm

Labels
module: bytebuddy ByteBuddy plugin type: enhancement New feature or enhancement to an existing one
Projects
None yet
Milestone
0.3
Development

No branches or pull requests
1 participant
@odrotbohm