Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DynamicLog claims to configure ManageDocks #215

Closed
geekosaur opened this issue Nov 13, 2017 · 3 comments
Closed

DynamicLog claims to configure ManageDocks #215

geekosaur opened this issue Nov 13, 2017 · 3 comments

Comments

@geekosaur
Copy link
Contributor

The statusBar combinator, and therefore dzen and xmobar, configure avoidStruts but not the other necessary hooks. This mostly worked before 0.12, but from 0.12 on its avoidStruts is ineffective without the other dock hooks. See #147.

The quick fix is probably to make it use docks. I am not sure that's a great idea in the case that the user's config already uses docks or individual hooks; duplicating hooks isn't a very good idea, especially docksStartupHook which has no choice but to enumerate all windows with XQueryTree in order to preload the strut cache.

@geekosaur
Copy link
Contributor Author

Come to think of it, we also should have a docksOn whioch uses avoidStrutsOn.

@slotThe
Copy link
Member

slotThe commented Mar 21, 2021

statusBar and variants have been using docks for quite some time, closing this.

@slotThe slotThe closed this as completed Mar 21, 2021
@liskin
Copy link
Member

liskin commented Mar 21, 2021

That, and #406 restored the pre-0.12 behaviour of not requiring the startup hook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants