Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port calc_vnr_pred to Avona #291

Closed
shuchitak opened this issue May 23, 2022 · 6 comments
Closed

Port calc_vnr_pred to Avona #291

shuchitak opened this issue May 23, 2022 · 6 comments

Comments

@shuchitak
Copy link
Collaborator

shuchitak commented May 23, 2022

calc_vnr_pred() needs to be ported to Avona. Once we have this, we can work on #255 and test keyword performance when passing VNR instead of VAD output to AGC.

@shuchitak
Copy link
Collaborator Author

I have it implemented here and need to add a unit test for it before starting #255

@shuchitak
Copy link
Collaborator Author

@shuchitak shuchitak added size:M and removed size:SM labels May 24, 2022
@shuchitak
Copy link
Collaborator Author

I have added the calc_vnr_pred function in the IC module and a unit test testing avona implementation against the py_ic model in https://github.com/shuchitak/sw_avona-1/tree/feature/calc_vnr_pred

The current challenge is to get the IC and stage_b tests that make use of the CFFI framework passing. Now that vnr is a dependency of IC, even though everything still compiles on x86, extracting the predefs the way it is done here is tricky for vnr due to the number of header files in the tflite micro library. I need to think more about this, so I've decided to increase the size label and story points for this issue.

@shuchitak
Copy link
Collaborator Author

#293

@shuchitak
Copy link
Collaborator Author

Merged #293

The calc_vnr_pred() version in py_ic hash 3826a6919b6a54f48b8ad72a06cc34ea6d4474da is ported to sw_avona. Since py_ic is being actively developed, this function will change, and will need updating in Avona. Keeping this issue open to track further changes to py_ic calc_vnr_pred()

@shuchitak
Copy link
Collaborator Author

calc_vnr_pred() ported to Avona is compatible with py_ic v2.0.0. Closing this issue now.

keithauxmos pushed a commit to keithauxmos/fwk_voice that referenced this issue Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants